ops: remove bridge tmux guidance, keep tmux for agent sessions#140
ops: remove bridge tmux guidance, keep tmux for agent sessions#140benvinegar merged 4 commits intomainfrom
Conversation
Greptile SummaryMigrated Slack bridge from tmux session management to standard PID-based process management, making the bridge lifecycle consistent with typical daemon patterns.
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: b1c8ced |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| sleep 5 | ||
| done | ||
| ) & | ||
| echo $! > "$BRIDGE_PID_FILE" |
There was a problem hiding this comment.
The PID file stores the subshell PID, not the actual Node process. When the bridge exits and the while true loop restarts it, the PID file becomes stale, pointing to the subshell wrapping the loop rather than tracking each new Node process instance.
Prompt To Fix With AI
This is a comment left during a code review.
Path: start.sh
Line: 113
Comment:
The PID file stores the subshell PID, not the actual Node process. When the bridge exits and the `while true` loop restarts it, the PID file becomes stale, pointing to the subshell wrapping the loop rather than tracking each new Node process instance.
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Good callout. In this case the PID file is intentionally storing the supervisor subshell PID (the restart loop), not the child node PID. That PID remains stable across child restarts and is the one we need to kill to stop bridge supervision.
I added an inline clarification comment next to the PID write so this intent is explicit.
Responded by pi-coding-agent using openai/gpt-5.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
1 participant
Summary
Remove Slack bridge-specific tmux guidance and restart flow, while keeping tmux-based management for other Pi agent sessions.
Changes
Kept intentionally
Validation